In-product acquisition updates #9552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous name was a little misleading.
This moves some logic from C# code to MSBuild targets, with a view to later moving that logic into the SDK. This change has a few ramifications: 1. IPA components no longer subscribe to evaluation data. Everything now comes from the DTB. 1. The mapping between `TargetFrameworkVersion` and VS component ID moves from C# to MSBuild. Ultimately it should move to the SDK, and this change helps facilitate that. 1. We have a simpler data exchange between targets and C#. Previously there was a `SuggestedWorkload` item that specified components. However we don't want to limit this feature to workloads. So the unpacking of workloads from the SDK to components happens in a target, and we just pass component IDs as item specs to the project system. 1. Allocate less memory by reusing portions of persistent collections where possible, instead of recreating new immutable instances.
This adds a subtree to the project node that displays the project's component IDs. To enable it, the user should add the `DiagnoseVisualStudioComponents` project capability.
drewnoakes
added
Tenet-User Friendly
drewnoakes
commented
Oct 10, 2024
drewnoakes
commented
Oct 10, 2024
docs/in-product-acquisition.md
Outdated
There was a problem hiding this comment.
This document is more of a spec for the IPA feature and doesn't reflect what was actually built. It should probably be trimmed heavily, and only content relevant to this repo kept.
adamint
approved these changes
Oct 15, 2024
...alStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Setup/ConfiguredSetupComponentSnapshot.cs
Show resolved
Hide resolved
...lStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Setup/SetupComponentRegistrationService.cs
Outdated
Show resolved
Hide resolved
...udio.ProjectSystem.Managed.VS/ProjectSystem/VS/Setup/VisualStudioComponentSubTreeProvider.cs
Show resolved
Hide resolved
smitpatel
approved these changes
Oct 15, 2024
drewnoakes
added a commit
to drewnoakes/project-system
that referenced
this pull request
Oct 25, 2024
Two recent PRs merged and caused a simple build break, which is fixed here. - dotnet#9561 - dotnet#9552
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9011
Contributes to #8186
Contributes to dotnet/sdk#25575
There are a few changes here:
When the project sets
<IsRoslynComponent>totrue, the relevant VS component is now provided to IPA so that the user can be prompted to install it if missing. This avoids confusion. Without this, no warning is given, but the user won't be able to get their analyzer or source generator to work.Moves some logic from C# code to MSBuild targets, with a view to later moving that logic into the SDK, meaning:
CollectSuggestedVisualStudioComponentIdstarget.TargetFrameworkVersionand VS component ID moves from C# to MSBuild. Ultimately it should move to the SDK, and this change helps facilitate that.SuggestedWorkloaditem that specified components. However, we don't want to limit this feature to workloads. So the unpacking of workloads from the SDK to components happens in a target, and we just pass component IDs as item specs to the project system.Allocate less memory by reusing portions of persistent collections where possible, instead of recreating new immutable instances.
Adds a diagnostic mode where the project node displays the project's component IDs. To enable it, the user should add the
DiagnoseVisualStudioComponentsproject capability. Solution Explorer will then display a new "Setup components" subtree, resembling:Microsoft Reviewers: Open in CodeFlow